Open
Conversation
Deny: collapsible_if, needless_bool, needless_return, redundant_else, manual_let_else, unnested_or_patterns, single_match_else, fn_params_excessive_bools, struct_excessive_bools Warn: cognitive_complexity, too_many_lines, match_same_arms Auto-fixed 11 violations (let-else, or-patterns, single-match). 97 warnings remain for future refactoring. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
wildcard_imports, uninlined_format_args, unused_self, needless_pass_by_value, redundant_closure, manual_string_new, needless_continue, cast_lossless, explicit_iter_loop, unnecessary_wraps, match_wildcard_for_single_variants Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #969
Summary
Adds a
[lints.clippy]section to Cargo.toml with strict rules:Deny (breaks CI):
collapsible_if,collapsible_else_if- no nested ifs that can be collapsedneedless_bool,needless_return- clean returnsredundant_else,manual_let_else- use let-else patternunnested_or_patterns,single_match_else- cleaner patternsfn_params_excessive_bools,struct_excessive_bools- no boolean spaghettiWarn (flags for refactoring):
cognitive_complexity- flags functions over complexity 25 (14 currently)too_many_lines- flags functions over 100 lines (37 currently)match_same_arms- flags duplicate match arms (33 currently)Auto-fixed 11 violations. 97 warnings remain as refactoring targets.
Test plan
🤖 Generated with Claude Code